cloudian: Set cloudian.connector.enabled as not dynamic#4938
Conversation
|
@blueorangutan package |
|
@davidjumani a Jenkins job has been kicked to build packages. I'll keep you posted as I make progress. |
|
Packaging result: ✔️ centos7 ✔️ centos8 ✔️ debian. SL-JID 435 |
|
@blueorangutan test |
|
@davidjumani a Trillian-Jenkins test job (centos7 mgmt + kvm-centos7) has been kicked to run smoke tests |
|
Trillian test result (tid-483)
|
|
|
||
| ConfigKey<Boolean> CloudianConnectorEnabled = new ConfigKey<>("Advanced", Boolean.class, "cloudian.connector.enabled", "false", | ||
| "If set to true, this enables the Cloudian Connector for CloudStack.", true); | ||
| "If set to true, this enables the Cloudian Connector for CloudStack.", false); |
There was a problem hiding this comment.
@davidjumani this won't work - maybe for UI but for the plugin to instantiate - you'll need to restart mgmt server, as it's used in the configure method of manager/class
There was a problem hiding this comment.
Exactly why it's being set as non dynamic. The user will get a notification that the MS needs to be restarted after this change and on restart it'll pick up the necessary API
There was a problem hiding this comment.
Ah I see, my bad I misunderstood - lgtm.
Description
This PR sets cloudian.connector.enabled as not dynamic since cloudian requires the cloudianSsoLogin API which is added only once the MS is restarted
Types of changes
Bug Severity